nastra commented on code in PR #11419:
URL: https://github.com/apache/iceberg/pull/11419#discussion_r1839960587
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWriterV2.java:
##########
@@ -244,4 +247,132 @@ public void testMergeSchemaSparkConfiguration() throws
Exception {
row(4L, "d", 140000.56F)),
sql("select * from %s order by id", tableName));
}
+
+ @TestTemplate
+ public void testMergeSchemaIgnoreCastingLongToInt() throws Exception {
+ sql(
+ "ALTER TABLE %s SET TBLPROPERTIES ('%s'='true')",
+ tableName, TableProperties.SPARK_WRITE_ACCEPT_ANY_SCHEMA);
+
+ Dataset<Row> bigintDF =
+ jsonToDF(
+ "id bigint, data string",
+ "{ \"id\": 1, \"data\": \"a\" }",
+ "{ \"id\": 2, \"data\": \"b\" }");
+
+ bigintDF.writeTo(tableName).append();
+
+ assertEquals(
+ "Should have initial rows with long column",
+ ImmutableList.of(row(1L, "a"), row(2L, "b")),
+ sql("select * from %s order by id", tableName));
+
+ Dataset<Row> intDF =
+ jsonToDF(
+ "id int, data string",
+ "{ \"id\": 3, \"data\": \"c\" }",
+ "{ \"id\": 4, \"data\": \"d\" }");
+
+ assertThatCode(() -> intDF.writeTo(tableName).option("merge-schema",
"true").append())
Review Comment:
nvm. the test fails when `merge-schema` is set to `true` but your fix isn't
applied. I think it would make sense to add a comment to make this clearer in
this test
##########
spark/v3.5/spark/src/test/java/org/apache/iceberg/spark/source/TestDataFrameWriterV2.java:
##########
@@ -244,4 +247,132 @@ public void testMergeSchemaSparkConfiguration() throws
Exception {
row(4L, "d", 140000.56F)),
sql("select * from %s order by id", tableName));
}
+
+ @TestTemplate
+ public void testMergeSchemaIgnoreCastingLongToInt() throws Exception {
+ sql(
+ "ALTER TABLE %s SET TBLPROPERTIES ('%s'='true')",
+ tableName, TableProperties.SPARK_WRITE_ACCEPT_ANY_SCHEMA);
Review Comment:
the test seems to pass independent of whether this is set or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
