nastra commented on code in PR #11419:
URL: https://github.com/apache/iceberg/pull/11419#discussion_r1841669608
##########
core/src/main/java/org/apache/iceberg/schema/UnionByNameVisitor.java:
##########
@@ -180,6 +180,23 @@ private void updateColumn(Types.NestedField field,
Types.NestedField existingFie
}
}
+ private boolean isIgnorableTypeUpdate(Type existingType, Type newType) {
+ if (existingType.isPrimitiveType()) {
+ /* TypeUtil.isPromotionAllowed is used to check whether type promotion
is allowed in the reverse order,
Review Comment:
thanks, the comment makes things much clearer. Could you please switch the
comment style from /*...*/ to // as the project doesn't generally use /*...*/
for in-line comments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
