kevinjqliu commented on issue #1284: URL: https://github.com/apache/iceberg-python/issues/1284#issuecomment-2469667659
> In general, I think the philosophy should be; that people don't have to worry about field IDs, and this should be hidden away. +1 > In the case of the table migration, that's some advanced situation where you don't want to re-assign the IDs We can have a function to explicitly assign IDs, such as `assign_fresh_schema_ids`. If Iceberg Schema is given, it will use its original assigned ID. If PyArrow Schemas is given, it will be converted to Iceberg Schemas and have IDs assigned. @sungwy WDYT of this method instead of adding the `assign_fresh_ids` flag to the functions? I think it doesn't make sense for the `create_table` function to have a flag for schema ID assignment. I guess the difference is, is there a case where I want to call `create_table` with Iceberg Schema and have `assign_fresh_ids=False`? Can the user just call `assign_fresh_schema_ids(iceberg_schema)` instead? We don't care about PyArrow Schemas since they are always converted and assigned IDs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
