Fokko commented on issue #1284:
URL: 
https://github.com/apache/iceberg-python/issues/1284#issuecomment-2454746766

   Thanks for bringing this up!
   
   > I'm excited about this change. This might also help us streamline 
create_table with partition_spec and sort_order since there's been an issue 
with the field_id mismatch.
   
   Indeed :) To provide some historical context. The idea was that PyIceberg 
was more of a library than an end-user tool, therefore it was always a second 
layer (like having PyArrow in front of it).
   
   In general, I think the philosophy should be; that people don't have to 
worry about field IDs, and this should be hidden away. In the case of the table 
migration, that's some advanced situation where you don't want to re-assign the 
IDs. I can think of two options:
   
   - Having a flag to not assign fresh IDs
   - Ability to have a custom assigning class, so you can also do other ways of 
assigning the IDs (pre-order, post-order etc).
   
   Keep in mind that the REST catalog also might re-assign IDs (I think the one 
we use in the integration tests also does this).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to