liurenjie1024 commented on issue #694: URL: https://github.com/apache/iceberg-rust/issues/694#issuecomment-2469423843
Here is the reason why I accept it: `SchemalessPartitionSpec` is used when we load table metadata and build partition spec from table metadata. Since there is no schema id associated with partition spec, in java it's built with `bindUncheck` with current schema in current snapshot. That's to say, java implementation assumes that the partiton specs are valid with current schema without checking. I'm skeptical that it's a safe approach. I agree with @c-thiel that it's not appropriate to use `UnboundPartitionSpec` since `UnboundPartitionSpec` means not validated, user constructed partition spec, which is not the case for partiton specs from table metadata. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
