c-thiel commented on issue #694: URL: https://github.com/apache/iceberg-rust/issues/694#issuecomment-2514191991
@Fokko didn't you try to remove the `buildUnchecked` in Java? Did you succeed? > Add a crate private buildUnchecked method. At least for `Lakekeeper` we would need `buildUnchecked` to be public. We are creating TableMetadata not from a big JSON blob, but instead from individual parts that we store in the Database in individual tables. This makes some operations around snapshots lightning fast, because we don't need to do a slow roundtrip to S3. We need the same fine-granular control publicly exposed that the MetadataBuilder is using internally as we would need to stay on a fork otherwise. Apart from that, my preference would still be to introduce a lightweight additional type that clearly states what its used for than to add a `buildUnchecked` method with lazy accessors that might panic if whoever wrote the Metadata file did not implement the checks accordingly - this includes all java and pyiceberg versions that are currently out. With `SchemalessPartitionSpec` we already have lazy field types, as we can just `.bind()` it at a later point in time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
