Fokko commented on issue #694: URL: https://github.com/apache/iceberg-rust/issues/694#issuecomment-2514536378
I've created https://github.com/apache/iceberg/pull/11604 to reflect my idea on the Java side. When you have `PartitionSpec` that references a field that has been dropped, then we can also drop it from the PartitionSpec, because we will never use it. Another option I'm noodling about, is replacing the type with the newly in V3 introduced `UnknownType`. > @Fokko didn't you try to remove the `buildUnchecked` in Java? Did you succeed? If we the PR I mentioned above in, we can remove the `buildUnchecked`. What I think is even better is to defer the binding to a later point like [we did in PyIceberg](https://github.com/apache/iceberg-python/blob/68e17af746021f630b7efa38a50b3ffb51a2dad8/pyiceberg/partitioning.py#L203-L225). This is performance wise probably also better, because you don't know yet which partition spec's you're going to encounter. I checked what the current situation is in PyIceberg, and there we need one similar check: https://github.com/apache/iceberg-python/pull/1393 The Avro reader will just skip the partition field that references the dropped field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
