jbonofre commented on code in PR #11427:
URL: https://github.com/apache/iceberg/pull/11427#discussion_r1827779665
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -123,7 +123,7 @@ enum SchemaVersion {
+ JdbcTableOperations.METADATA_LOCATION_PROP
+ " = ?";
static final String V0_CREATE_CATALOG_SQL =
- "CREATE TABLE "
+ "CREATE TABLE IF NOT EXISTS "
Review Comment:
Yes, it's what I said: SQLServer doesn't support it.
I think we have two options:
1. We clearly state that SQLServer is not supported
2. I prefer to keep the current approach using `dbMeta`. I would probably
add an extra check to define if tables have to be created or not.
I'm more in favour of 2 as it would work with any RDBMS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
