jbonofre commented on code in PR #11427:
URL: https://github.com/apache/iceberg/pull/11427#discussion_r1822324504
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -123,7 +123,7 @@ enum SchemaVersion {
+ JdbcTableOperations.METADATA_LOCATION_PROP
+ " = ?";
static final String V0_CREATE_CATALOG_SQL =
- "CREATE TABLE "
+ "CREATE TABLE IF NOT EXISTS "
Review Comment:
The reason why we use JDBC table check (via catalog) and not the `IF NOT
EXISTS` statement is to work with any RDBMS.
To my knowledge, some databases don't support `IF NOT EXISTS` statement.
`IF NOT EXISTS` has been introduced in Oracle Database 23c, and it's
supported by MySQL, MariaDB, PostgreSQL and SQLite, but not by SQLServer.
So, no problem to use this approach as soon as we clearly state that
SQLServer won't be supported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
