FANNG1 commented on code in PR #11427:
URL: https://github.com/apache/iceberg/pull/11427#discussion_r1824081295
##########
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##########
@@ -123,7 +123,7 @@ enum SchemaVersion {
+ JdbcTableOperations.METADATA_LOCATION_PROP
+ " = ?";
static final String V0_CREATE_CATALOG_SQL =
- "CREATE TABLE "
+ "CREATE TABLE IF NOT EXISTS "
Review Comment:
I tested SQLServer and it doesn't support `CREATE TABLE IF NOT EXISTS`,
seems this is not the correct direction if Iceberg still supports SQLServer as
JDBC catalog backend. How about double check the database and table
information from the `ResultSet` returned by `dbMeta.getTables`, is it the
right direction?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
