flyrain commented on code in PR #11390:
URL: https://github.com/apache/iceberg/pull/11390#discussion_r1826877729
##########
parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java:
##########
@@ -181,8 +184,8 @@ boolean[] shouldSkip() {
return shouldSkip;
}
- private Map<Long, Long> generateOffsetToStartPos(Schema schema) {
- if (schema.findField(MetadataColumns.ROW_POSITION.fieldId()) == null) {
+ private Map<Long, Long> generateOffsetToStartPos() {
+ if (hasPositionDelete) {
Review Comment:
BTW, we don't actually need this if this PR#10107 is in, which removes
related complexity. The parquet side is ready for a while. We may get #10107
in.
##########
parquet/src/main/java/org/apache/iceberg/parquet/ReadConf.java:
##########
@@ -181,8 +184,8 @@ boolean[] shouldSkip() {
return shouldSkip;
}
- private Map<Long, Long> generateOffsetToStartPos(Schema schema) {
- if (schema.findField(MetadataColumns.ROW_POSITION.fieldId()) == null) {
+ private Map<Long, Long> generateOffsetToStartPos() {
+ if (hasPositionDelete) {
Review Comment:
BTW, we don't actually need this if this PR #10107 is in, which removes
related complexity. The parquet side is ready for a while. We may get #10107
in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
