RussellSpitzer commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1819329112
##########
core/src/main/java/org/apache/iceberg/PartitionStats.java:
##########
@@ -249,4 +250,45 @@ public <T> void set(int pos, T value) {
throw new UnsupportedOperationException("Unknown position: " + pos);
}
}
+
+ @Override
+ @SuppressWarnings("checkstyle:CyclomaticComplexity")
+ public boolean equals(Object other) {
+ if (this == other) {
+ return true;
+ } else if (!(other instanceof PartitionStats)) {
+ return false;
+ }
+
+ PartitionStats that = (PartitionStats) other;
+ return Objects.equals(partition, that.partition)
Review Comment:
Sorry but we can't assume subtype here unless you want to assert and change
the field type above. If we say something is structLike we can't assume it
behaves like a record (even if given the current code we know it won't.) If you
want it to be a record you need to cast it and assert earlier in the class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
