ajantha-bhat commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1851202734


##########
core/src/main/java/org/apache/iceberg/PartitionStats.java:
##########
@@ -205,6 +211,8 @@ public <T> T get(int pos, Class<T> javaClass) {
   public <T> void set(int pos, T value) {
     switch (pos) {
       case 0:
+        Preconditions.checkArgument(

Review Comment:
   I can keep the member as `Record` instead of `StructLike` to avoid this. But 
since we have plan to use internal writers in future (which uses `StructLike`), 
we lose compatibility if we keep the member as `Record` instead of `StructLike`.
   
   I don't think it is too awkward as `Record` implements `StructLike`. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to