ajantha-bhat commented on code in PR #11216:
URL: https://github.com/apache/iceberg/pull/11216#discussion_r1848581399
##########
core/src/main/java/org/apache/iceberg/PartitionStats.java:
##########
@@ -249,4 +250,45 @@ public <T> void set(int pos, T value) {
throw new UnsupportedOperationException("Unknown position: " + pos);
}
}
+
+ @Override
+ @SuppressWarnings("checkstyle:CyclomaticComplexity")
+ public boolean equals(Object other) {
+ if (this == other) {
+ return true;
+ } else if (!(other instanceof PartitionStats)) {
+ return false;
+ }
+
+ PartitionStats that = (PartitionStats) other;
+ return Objects.equals(partition, that.partition)
Review Comment:
Agree. I have added the assert (preconditions) to make sure it is always of
the type Record. Also, added a comment that why keeping the type as StructType
instead of Record when it is always a record.
It is because in future when we introduce internal parquet writers that
works with StructLike instead of Record, we don't have to change method
signatures and it will be compatible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
