munendrasn commented on code in PR #10873:
URL: https://github.com/apache/iceberg/pull/10873#discussion_r1795529647


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2763,7 +2763,8 @@ components:
         
         ## General Configurations
         
-        - `token`: Authorization bearer token to use for table requests if 
OAuth2 security is enabled 
+        - `token`: Authorization bearer token to use for table requests if 
OAuth2 security is enabled
+        - `expires-at-ms`: if present, specifies timestamp in milliseconds 
when credentials for storage(AWS S3/Azure/), specified in config would expire

Review Comment:
   I was thinking to keep the `config` properties aligned with #10722 , will 
revisit this once the credential standardisation is finalised



##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2763,7 +2763,8 @@ components:
         
         ## General Configurations
         
-        - `token`: Authorization bearer token to use for table requests if 
OAuth2 security is enabled 
+        - `token`: Authorization bearer token to use for table requests if 
OAuth2 security is enabled
+        - `expires-at-ms`: if present, specifies timestamp in milliseconds 
when credentials for storage(AWS S3/Azure/), specified in config would expire

Review Comment:
   I was thinking to keep the `config` properties aligned with #10722 , will 
revisit this once the credential standardisation is finalised



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to