adutra commented on code in PR #10873:
URL: https://github.com/apache/iceberg/pull/10873#discussion_r1761071312
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2763,7 +2763,8 @@ components:
## General Configurations
- - `token`: Authorization bearer token to use for table requests if
OAuth2 security is enabled
+ - `token`: Authorization bearer token to use for table requests if
OAuth2 security is enabled
+ - `expires-at-ms`: if present, specifies timestamp in milliseconds
when credentials for storage(AWS S3/Azure/), specified in config would expire
Review Comment:
Also, can we make it clear that it's about credentials? Maybe
`credentials-expire-at-ms`? Because as it is, the reader would naively think
it's the table itself that expires, or even worse, that it's the `token` above
that expires.
##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -2763,7 +2763,8 @@ components:
## General Configurations
- - `token`: Authorization bearer token to use for table requests if
OAuth2 security is enabled
+ - `token`: Authorization bearer token to use for table requests if
OAuth2 security is enabled
+ - `expires-at-ms`: if present, specifies timestamp in milliseconds
when credentials for storage(AWS S3/Azure/), specified in config would expire
Review Comment:
```suggestion
- `expires-at-ms`: if present, specifies timestamp in milliseconds
when credentials for storage(AWS S3/Azure/GCP), specified in config would expire
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
