munendrasn commented on code in PR #10873:
URL: https://github.com/apache/iceberg/pull/10873#discussion_r1804979997


##########
open-api/rest-catalog-open-api.py:
##########
@@ -1103,6 +1103,7 @@ class LoadTableResult(BaseModel):
     ## General Configurations
 
     - `token`: Authorization bearer token to use for table requests if OAuth2 
security is enabled
+    - `expires-at-ms`: if present, specifies timestamp in milliseconds when 
credentials for storage(AWS S3/Azure/GCP), specified in config would expire

Review Comment:
   Based on 
https://github.com/apache/iceberg/pull/10722#discussion_r1796948974, I was 
thinking to move/add this to fileIo Properties once linked PRs in the 
description are merged
   I saw this 
[comment](https://github.com/apache/iceberg/pull/11281#discussion_r1804199315), 
where it was decided not having the separate property. 
   It would be beneficial to have this property but will yet to go through the 
recording of Catalog sync (recording is not yet 
[available](https://docs.google.com/document/d/1iPGVCIcr-M0XtAiudOguWAvmqIdVgpYN5vz5ohO8PKw/edit?tab=t.0))



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to