RussellSpitzer commented on code in PR #11258:
URL: https://github.com/apache/iceberg/pull/11258#discussion_r1792496212
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java:
##########
@@ -132,7 +135,9 @@ private void ensureWriterInitialized() {
@Override
public void add(T value) {
recordCount += 1;
+ long sizeBeforeWrite = writeStore.getBufferedSize();
Review Comment:
We are now calling getBufferedSize for every value, this seems like a big
perf difference? Can we run the write benchmarks with this on and off?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
