RussellSpitzer commented on code in PR #11258:
URL: https://github.com/apache/iceberg/pull/11258#discussion_r1792493504
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java:
##########
@@ -66,6 +66,9 @@ class ParquetWriter<T> implements FileAppender<T>, Closeable {
private boolean closed;
private ParquetFileWriter writer;
private int rowGroupOrdinal;
+ private long currentRawBufferedSize = 0;
Review Comment:
So for my own clarity this is
currentRawBufferedSize = The amount of "buffer" in the currentRowGroup
calculated as a diff in getBufferedSize()
toatalRawBufferedSIze = The amount of "buffer" in all RowGroups calculated
as a diff in getBufferedSize()
totalRowGroupSize = The amount of "buffer" in all RowGroups calculated by
just adding getBufferedSize() for each rowgroup together
##########
parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java:
##########
@@ -66,6 +66,9 @@ class ParquetWriter<T> implements FileAppender<T>, Closeable {
private boolean closed;
private ParquetFileWriter writer;
private int rowGroupOrdinal;
+ private long currentRawBufferedSize = 0;
Review Comment:
Is this right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
