jackye1995 commented on PR #11112: URL: https://github.com/apache/iceberg/pull/11112#issuecomment-2374861417
Sorry for the late review, was busy with some internal work... > it also seems like it would fit cleanly into the existing ObjectStoreLocationProvider as opposed to a separate provider. +1 for that. I think the main concern was that this seems to be too S3 specific, but if there is no major concern from others I am good with changing the ObjectStoreLocationProvider directly, that actually helps adoption. > think we also need to consider adding a path separator to help with some of the maintenance routines. I reviewed the internal experiments related to this, and having no path separators as well as having at least 24 bits I believe are all important based on load testing. If the concern is compatibility with other systems, would it make sense to only use this approach for locations that begins with `s3://` or `s3a://`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
