gaborkaszab commented on PR #5837: URL: https://github.com/apache/iceberg/pull/5837#issuecomment-2363706681
Thanks for taking a look @findepi , @Fokko! So far I don't see any reason why this can't be merged. Not as it is now but probably reverting to the initial version that didn't have the more general, MultiDimensionCounter approach. There were two concerns that I think I addressed: Whether a multi file format scenario can happen in real life, and the answer is yes, this happens more frequently for some huge users than one could imagine. The other concern was about bloating the metadata files, but these metrics aren't persisted there so this also shouldn't be a concern. Could you help me how I can get this PR going? May I rebase and revert to the original, more simple version? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
