Fokko commented on PR #5837: URL: https://github.com/apache/iceberg/pull/5837#issuecomment-2315744223
First of all, sorry for not jumping into this earlier. > 1) extra metrics never hurt This is unfortunately not true. The metadata JSON grows quite big in bytes very easily, and this is a common complaint that I see across channels. The snapshot-summary is one of the parts that add a lot of content to the table metadata. Unless there is a good reason to add additional fields to there, I'm reluctant to add new fields. > 3) having thorough metrics on a production-grade software is inevitable for debugging, supportability and observability, query engines have 100s if not 1000s of them. If you need to debug, also listing the manifests files is pretty straightforward to also collect these metrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
