nastra commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1750335281
##########
aws/src/test/java/org/apache/iceberg/aws/s3/TestS3FileIOProperties.java:
##########
@@ -491,4 +493,17 @@ public void testApplyUserAgentConfigurations() {
Mockito.verify(mockS3ClientBuilder)
.overrideConfiguration(Mockito.any(ClientOverrideConfiguration.class));
}
+
+ @Test
+ public void testApplyRetryConfiguration() {
+ Map<String, String> properties = Maps.newHashMap();
+ properties.put(S3FileIOProperties.S3_RETRY_NUM_RETRIES, "999");
+ S3FileIOProperties s3FileIOProperties = new S3FileIOProperties(properties);
+
+ S3ClientBuilder builder = S3Client.builder();
+ s3FileIOProperties.applyRetryConfigurations(builder);
+
+ RetryPolicy retryPolicy =
builder.overrideConfiguration().retryPolicy().get();
+ assertThat(retryPolicy.numRetries()).withFailMessage("retries was not
set").isEqualTo(999);
Review Comment:
```suggestion
assertThat(retryPolicy.numRetries()).as("retries was not
set").isEqualTo(999);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
