nastra commented on code in PR #11052:
URL: https://github.com/apache/iceberg/pull/11052#discussion_r1760984150


##########
docs/docs/aws.md:
##########
@@ -378,6 +378,19 @@ However, for the older versions up to 0.12.0, the logic is 
as follows:
 
 For more details, please refer to the [LocationProvider 
Configuration](custom-catalog.md#custom-location-provider-implementation) 
section.  
 
+### S3 Retries
+
+Workloads which encounter S3 throttling should persistently retry, with 
exponential backoff, to make progress while S3
+automatically scales. The default values for S3 retries are tuned such that 
most workloads that encounter throttling will
+make progress without failing due to retry exhaustion. For workloads with 
exceptionally high throughput against tables
+that S3 has not yet scaled, it may be necessary to increase the retry count 
further.
+
+| Property             | Default | Description                                 
    |
+|----------------------|---------|-------------------------------------------------|
+| s3.retry.num-retries | 32      | Number of times to retry S3 operations.     
    |
+| s3.retry.min-wait-ms | 500ms   | Minimum wait time to retry a S3 operation.  
    |

Review Comment:
   the default here doesn't match what's in the code



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to