liurenjie1024 commented on PR #558: URL: https://github.com/apache/iceberg-rust/pull/558#issuecomment-2295199077
Thanks @sdd for this pr. I just skimmed through it and thought that it's great! My suggestion is to split this pr into two smaller ones: one for row group and one for page index. You can see that without tests this pr is already nearly 1.6k+ lines, and it would be too large to review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
