AndreMouche commented on PR #539: URL: https://github.com/apache/iceberg-rust/pull/539#issuecomment-2296250513
> Also please note that ArrowSchemaVisitor is a framework for processing ArrowSchema in visitor pattern, not only designed for iceberg schema converter. We will use it later when processing parquet files.**** make sense to me. However, I still have few question about it. Now it seems that we could use `ArrowSchemaConverter` in visitor pattern, could we make `visit_type`, `visit_list` as the as the function to `ArrowSchemaConverter` ? `ArrowSchemaConverter` is designed as a tool to convert arrow_chema only, or a tool can convert shema and data types? Meanwhile, about the interface `ArrowSchemaVisitor` https://github.com/apache/iceberg-rust/blob/a1ec0fa98113fc02b2479d81759fccd9dab10378/crates/iceberg/src/arrow/schema.rs#L96-L108 For example, we already know `list` should be a struct List, why we do not take the element_field of the list as the arguments directly? Meanwhile, since `ArrowSchemaVisitor` is a general interface, could you please make the definitions of each interface function be made clearer? which will be very helpful for new newcomers like me, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
