AndreMouche commented on PR #539:
URL: https://github.com/apache/iceberg-rust/pull/539#issuecomment-2296194586
> Is there any performance number to comprare these two methods?
Comparison of bench test results between current PR and master branches:
current branch:
```
➜ iceberg-rust git:(convert_arrow_filed_to_iceberg_field) ✗ cargo bench
--package iceberg --lib --
arrow::schema::tests::bench_complex_arrow_schema_to_iceberg --exact
--show-output
Finished `bench` profile [optimized] target(s) in 0.67s
Running unittests src/lib.rs
(target/release/deps/iceberg-ba39310710f5b54e)
running 1 test
test arrow::schema::tests::bench_complex_arrow_schema_to_iceberg ... bench:
29,431,166.70 ns/iter (+/- 1,098,685.87)
successes:
successes:
test result: ok. 0 passed; 0 failed; 0 ignored; 1 measured; 456 filtered
out; finished in 9.02s
➜ iceberg-rust git:(convert_arrow_filed_to_iceberg_field) ✗ cargo bench
--package iceberg --lib --
arrow::schema::tests::bench_complex_arrow_schema_to_iceberg --exact
--show-output
Finished `bench` profile [optimized] target(s) in 0.56s
Running unittests src/lib.rs
(target/release/deps/iceberg-ba39310710f5b54e)
running 1 test
test arrow::schema::tests::bench_complex_arrow_schema_to_iceberg ... bench:
29,581,220.90 ns/iter (+/- 775,051.14)
successes:
successes:
test result: ok. 0 passed; 0 failed; 0 ignored; 1 measured; 456 filtered
out; finished in 8.94s
```
master @ #567
```
➜ iceberg-rust git:(bench_mark_arrow_schema) cargo bench --package iceberg
--lib -- arrow::schema::tests::bench_complex_arrow_schema_to_iceberg --exact
--show-output
Finished `bench` profile [optimized] target(s) in 0.32s
Running unittests src/lib.rs
(target/release/deps/iceberg-ba39310710f5b54e)
running 1 test
test arrow::schema::tests::bench_complex_arrow_schema_to_iceberg ... bench:
30,535,066.60 ns/iter (+/- 640,812.07)
successes:
successes:
test result: ok. 0 passed; 0 failed; 0 ignored; 1 measured; 456 filtered
out; finished in 9.26s
➜ iceberg-rust git:(bench_mark_arrow_schema) cargo bench --package iceberg
--lib -- arrow::schema::tests::bench_complex_arrow_schema_to_iceberg --exact
--show-output
Finished `bench` profile [optimized] target(s) in 0.32s
Running unittests src/lib.rs
(target/release/deps/iceberg-ba39310710f5b54e)
running 1 test
test arrow::schema::tests::bench_complex_arrow_schema_to_iceberg ... bench:
30,707,408.30 ns/iter (+/- 1,031,892.12)
successes:
successes:
test result: ok. 0 passed; 0 failed; 0 ignored; 1 measured; 456 filtered
out; finished in 9.30s
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
