liurenjie1024 commented on PR #539: URL: https://github.com/apache/iceberg-rust/pull/539#issuecomment-2294593295
Hi, @AndreMouche Thanks for your contribution, I have some concerns for this pr: > for performance: remove unnecessary match operations that could have a negative impact on performance. Is there any performance number to comprare these two methods? Also please note that `ArrowSchemaVisitor` is a framework for processing `ArrowSchema` in visitor pattern, not only designed for iceberg schema converter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
