RussellSpitzer commented on code in PR #10943: URL: https://github.com/apache/iceberg/pull/10943#discussion_r1720000122
########## parquet/src/main/java/org/apache/iceberg/parquet/VectorizedParquetReader.java: ########## @@ -141,8 +148,15 @@ public T next() { advance(); } + long remainingValues = nextRowGroupStart - valuesRead; + int remainingLimit = (int) (pushedLimit - valuesRead); Review Comment: It also strange that we track remaining limit in int and remaining values in long, but probably not a real world concern -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org