huaxingao commented on code in PR #10943:
URL: https://github.com/apache/iceberg/pull/10943#discussion_r1720099765
##########
spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkSQLProperties.java:
##########
@@ -45,6 +45,10 @@ private SparkSQLProperties() {}
"spark.sql.iceberg.aggregate-push-down.enabled";
public static final boolean AGGREGATE_PUSH_DOWN_ENABLED_DEFAULT = true;
+ // Controls whether to push down limit to Iceberg
+ public static final String LIMIT_PUSH_DOWN_ENABLED =
"spark.sql.iceberg.limit-push-down.enabled";
+ public static final boolean LIMIT_PUSH_DOWN_ENABLED_DEFAULT = true;
Review Comment:
This is not honored for ORC/Avro, but I think we should be able to push the
limit down for ORC/Avro. I prefer to keep the current namespace and make it
work for ORC/Avro. I will take a look at how ORC/Avro works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
