RussellSpitzer commented on code in PR #10943: URL: https://github.com/apache/iceberg/pull/10943#discussion_r1719059739
########## parquet/src/main/java/org/apache/iceberg/parquet/ParquetReader.java: ########## @@ -117,7 +122,12 @@ private static class FileIterator<T> implements CloseableIterator<T> { @Override public boolean hasNext() { - return valuesRead < totalValues; + long numToRead = totalValues; + if (pushedLimit > 0 && pushedLimit < numToRead) { Review Comment: The special casing of -1/0 makes our logic more complicated here, maybe we should reconsider? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org