RussellSpitzer commented on code in PR #10943:
URL: https://github.com/apache/iceberg/pull/10943#discussion_r1719053493
##########
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/parquet/VectorizedColumnIterator.java:
##########
@@ -69,12 +69,14 @@ public boolean producesDictionaryEncodedVector() {
}
public abstract class BatchReader {
- public void nextBatch(FieldVector fieldVector, int typeWidth,
NullabilityHolder holder) {
+ public void nextBatch(
+ int numValsToRead, FieldVector fieldVector, int typeWidth,
NullabilityHolder holder) {
Review Comment:
Not sure how likely this is, but is "int" safe here? With compression we
could have a vector that theoretically represents over INT.MAX rows. Maybe
that's not a real concern though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
