rdblue commented on code in PR #10929:
URL: https://github.com/apache/iceberg/pull/10929#discussion_r1715626412
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -229,6 +253,11 @@ public void initialize(String name, Map<String, String>
unresolved) {
// build the final configuration and set up the catalog's auth
Map<String, String> mergedProps = config.merge(props);
Map<String, String> baseHeaders = configHeaders(mergedProps);
+ this.endpoints = ImmutableSet.copyOf(config.endpoints());
+ if (endpoints.isEmpty()) {
Review Comment:
Nit: why not check if `config.endpoints()` is present and set
`this.endpoints` just once?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
