nastra commented on code in PR #10929:
URL: https://github.com/apache/iceberg/pull/10929#discussion_r1716612210


##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -352,8 +386,17 @@ public boolean dropTable(SessionContext context, 
TableIdentifier identifier) {
     }
   }
 
+  private void checkEndpointSupported(Endpoint endpoint) {
+    Preconditions.checkState(

Review Comment:
   I was going back and forth on which exception to throw but 
`UnsupportedOperationException` seems to be more appropriate here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to