rdblue commented on code in PR #10929:
URL: https://github.com/apache/iceberg/pull/10929#discussion_r1715625606
##########
core/src/main/java/org/apache/iceberg/rest/RESTSessionCatalog.java:
##########
@@ -132,6 +132,29 @@ public class RESTSessionCatalog extends
BaseViewSessionCatalog
.addAll(TOKEN_PREFERENCE_ORDER)
.build();
+ private static final Set<Endpoint> DEFAULT_ENDPOINTS =
+ ImmutableSet.<Endpoint>builder()
+ .add(ResourcePaths.V1_LIST_NAMESPACES)
+ .add(ResourcePaths.V1_LOAD_NAMESPACE)
+ .add(ResourcePaths.V1_CREATE_NAMESPACE)
+ .add(ResourcePaths.V1_UPDATE_NAMESPACE)
+ .add(ResourcePaths.V1_DELETE_NAMESPACE)
+ .add(ResourcePaths.V1_LIST_TABLES)
+ .add(ResourcePaths.V1_LOAD_TABLE)
+ .add(ResourcePaths.V1_CREATE_TABLE)
+ .add(ResourcePaths.V1_UPDATE_TABLE)
+ .add(ResourcePaths.V1_DELETE_TABLE)
+ .add(ResourcePaths.V1_RENAME_TABLE)
+ .add(ResourcePaths.V1_REGISTER_TABLE)
+ .add(ResourcePaths.V1_REPORT_METRICS)
+ .add(ResourcePaths.V1_LIST_VIEWS)
+ .add(ResourcePaths.V1_LOAD_VIEW)
+ .add(ResourcePaths.V1_CREATE_VIEW)
+ .add(ResourcePaths.V1_UPDATE_VIEW)
+ .add(ResourcePaths.V1_DELETE_VIEW)
+ .add(ResourcePaths.V1_RENAME_VIEW)
Review Comment:
By including view routes, this fails to solve the problem that we set out to
address. That basically means that we have to add new handling to see if
`endpoints` was sent to the locations with that ambiguous error handling,
making the code more complicated rather than fixing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
