amogh-jahagirdar commented on code in PR #10721:
URL: https://github.com/apache/iceberg/pull/10721#discussion_r1706410889
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3FileIOIntegration.java:
##########
@@ -106,6 +109,12 @@ public static void beforeClass() {
AwsIntegTestUtil.createAccessPoint(s3Control, accessPointName, bucketName);
AwsIntegTestUtil.createAccessPoint(
crossRegionS3Control, crossRegionAccessPointName,
crossRegionBucketName);
+ s3.putBucketVersioning(
+ PutBucketVersioningRequest.builder()
+ .bucket(bucketName)
+ .versioningConfiguration(
+
VersioningConfiguration.builder().status(BucketVersioningStatus.ENABLED).build())
Review Comment:
The simplest way for integration tests seemed to be just to enable bucket
versioning for the bucket and then on cleanup, ensure deletion of every object
version to make sure no garbage is left over.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
