advancedxy commented on code in PR #10755: URL: https://github.com/apache/iceberg/pull/10755#discussion_r1696223028
########## api/src/main/java/org/apache/iceberg/RemoveUnusedSpecs.java: ########## @@ -0,0 +1,29 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg; + +import java.util.List; + +/** + * API for removing partition specs from the metadata which are not the default spec and no longer + * refer to any datafiles in the table. + * + * <p>{@link #apply()} returns the specs that will remain if committed on the current metadata + */ +public interface RemoveUnusedSpecs extends PendingUpdate<List<PartitionSpec>> {} Review Comment: Missed this comment. I think it would be wonderful to be able to remove unused schemas as well. However, it might depends on #4898 to reliably determine which schemaId is still in use. > Does this need to be a separate operation? I think so, even if we are going to group other maintenance API like remove unused schema together, they are two different operations and should be in a dedicated operation. > I wonder if it is worth adding a maintenance API that could cover more things, like removing old schemas as well. Do you by chance have any API name for the `Metadata Maintenance` class? I am think about something like `MetadataCleaner`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
