rdblue commented on code in PR #10755:
URL: https://github.com/apache/iceberg/pull/10755#discussion_r1696101726
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1102,6 +1121,22 @@ public Builder setDefaultPartitionSpec(int specId) {
return this;
}
+ private Builder removePartitionSpec(PartitionSpec spec) {
+ Preconditions.checkArgument(
+ changes.isEmpty(), "Cannot remove partition spec with other metadata
update");
Review Comment:
I think this is needed to avoid conflicts with changes to the default spec
ID. I'd probably change this to allow other changes and instead update this and
the methods that set the default spec ID to check for one another.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
