alexyin1 opened a new pull request, #489: URL: https://github.com/apache/iceberg-rust/pull/489
Close [#474](https://github.com/apache/iceberg-rust/issues/474) This PR adds podman support by updating the get "Os/Arch" code in docker.rs and some configuration tricks. In addition, * "links" keyword is refactored to be "network" * std::net::IpAddr and SocketAddr are used for better type safety * Podman documentation is also added. * "expose" keyword used throughout, as opposed to "ports" Tested on arm64 MacOS with OrbStack and amd64 RHEL 8 with podman, docker compose. Some minor concerns: 1. What is the purpose of `ARG BUILDPLATFORM` and when/where should that be used? It was only present in one of the Dockerfiles, so I removed it. 2. Is there a cleaner way of having "CONTRIBUTING.MD" appear in the website and as a toplevel file in the github? It's a little tricky getting both the "github.com" version and the "rust.iceberg.apache.org" version to render links correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
