RussellSpitzer commented on code in PR #10736: URL: https://github.com/apache/iceberg/pull/10736#discussion_r1690468371
########## api/src/main/java/org/apache/iceberg/UpdatePartitionSpec.java: ########## @@ -122,4 +122,13 @@ public interface UpdatePartitionSpec extends PendingUpdate<PartitionSpec> { * change conflicts with other additions, removals, or renames. */ UpdatePartitionSpec renameField(String name, String newName); + + /** + * Sets whether the new partition spec will be set as the default partition spec for the table, + * the default behavior is to do so. + * + * @param value whether to set the new partition spec as default + * @return this for method chaining + */ + UpdatePartitionSpec setAsDefault(Boolean value); Review Comment: we could do a no arg method instead something like notDefault() -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org