amogh-jahagirdar commented on code in PR #10736:
URL: https://github.com/apache/iceberg/pull/10736#discussion_r1690457935
##########
core/src/main/java/org/apache/iceberg/BaseUpdatePartitionSpec.java:
##########
@@ -327,7 +336,12 @@ public PartitionSpec apply() {
@Override
public void commit() {
- TableMetadata update = base.updatePartitionSpec(apply());
+ TableMetadata update;
+ if (this.setAsDefault) {
Review Comment:
typically in the project, `this` is only used when writing to the field.
Here we could just reference `setAsDefault`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
