hussein-awala commented on code in PR #10771:
URL: https://github.com/apache/iceberg/pull/10771#discussion_r1690391598
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -512,7 +531,10 @@ private boolean isValidateNamespace(Namespace namespace) {
public TableOperations newTableOps(TableIdentifier tableIdentifier) {
String dbName = tableIdentifier.namespace().level(0);
String tableName = tableIdentifier.name();
- return new HiveTableOperations(conf, clients, fileIO, name, dbName,
tableName);
+ HiveTableOperations hiveTableOperations =
+ new HiveTableOperations(conf, clients, fileIO, name, dbName,
tableName);
+ fileIOCloser.put(hiveTableOperations, hiveTableOperations.io());
Review Comment:
I tried to move it to uplevel but I found some subclasses without a FileIO
instance (`ViewAwareTableBuilder` and `HadoopCatalogTableBuilder`), if you have
any suggestions to generalize it, I'm open to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
