amogh-jahagirdar commented on code in PR #10771:
URL: https://github.com/apache/iceberg/pull/10771#discussion_r1690386787
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -512,7 +531,10 @@ private boolean isValidateNamespace(Namespace namespace) {
public TableOperations newTableOps(TableIdentifier tableIdentifier) {
String dbName = tableIdentifier.namespace().level(0);
String tableName = tableIdentifier.name();
- return new HiveTableOperations(conf, clients, fileIO, name, dbName,
tableName);
+ HiveTableOperations hiveTableOperations =
+ new HiveTableOperations(conf, clients, fileIO, name, dbName,
tableName);
+ fileIOCloser.put(hiveTableOperations, hiveTableOperations.io());
Review Comment:
Something I've wondered for a bit, is it possible to uplevel any of this
logic to `BaseMetastoreCatalog` so that we avoid having every catalog which
extends from that to have it's own Cache<TableOperations, FileIO>?
Or does that not generalize? Not a blocker, but just wanted to make sure we
at least thought through it to avoid duplication.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
