nastra commented on code in PR #10771:
URL: https://github.com/apache/iceberg/pull/10771#discussion_r1689813754
##########
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java:
##########
@@ -636,6 +637,12 @@ protected Map<String, String> properties() {
return catalogProperties == null ? ImmutableMap.of() : catalogProperties;
}
+ @Override
+ public void close() throws IOException {
+ super.close();
+ fileIO.close();
Review Comment:
`fileIO` could be null at this point if initialization failed and close is
called immediately after it, so it would be good to add a null check.
Generally speaking, there's no guarantee that adding `close()` here actually
fixes the exception you mentioned in the PR. You would most likely need a
similar concept to what was introduced by #7487 / #8315
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
