sdd commented on code in PR #373:
URL: https://github.com/apache/iceberg-rust/pull/373#discussion_r1690195558
##########
crates/iceberg/src/expr/predicate.rs:
##########
@@ -668,6 +668,10 @@ pub enum BoundPredicate {
Set(SetExpression<BoundReference>),
}
+/// Newtype to prevent accidentally confusing predicates that are bound to a
partition with ones that are bound to a schema.
+#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
+pub struct PartitionBoundPredicate(pub(crate) BoundPredicate);
Review Comment:
Fair enough. Happy to remove. I only added because I got so annoyed after
spending hours tracking down a bug that was because I had confused the two that
I never wanted to have that pain again, but since then I've been more
consistent with the variable names. 😁
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
