Xuanwo commented on code in PR #373:
URL: https://github.com/apache/iceberg-rust/pull/373#discussion_r1690020806
##########
crates/iceberg/src/expr/predicate.rs:
##########
@@ -668,6 +668,10 @@ pub enum BoundPredicate {
Set(SetExpression<BoundReference>),
}
+/// Newtype to prevent accidentally confusing predicates that are bound to a
partition with ones that are bound to a schema.
+#[derive(Debug, Clone, Serialize, Deserialize, PartialEq)]
+pub struct PartitionBoundPredicate(pub(crate) BoundPredicate);
Review Comment:
Yes, I don't think the confusion is significant enough to require a new-type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
