stevenzwu commented on code in PR #10496:
URL: https://github.com/apache/iceberg/pull/10496#discussion_r1687162470
##########
api/src/main/java/org/apache/iceberg/StructTransform.java:
##########
@@ -125,6 +151,11 @@ public int hashCode() {
return Arrays.hashCode(transformedTuple);
}
+ /** Return the schema of transformed result (a flattened structure) */
+ public Schema resultSchema() {
Review Comment:
Do you mean `List<NestedField>` or `List<Type>`? the former still requires
field ids.
For my use case (Flink sink shuffling), we want to use
`StructLikeComparator` to compare the `SortKey` values. Hence need the result
schema of the `SortKey/StructTransform`.
```
this.comparator = Comparators.forType(sortKey.resultSchema().asStruct());
```
Admittedly, the field ids and names here aren't very meaningful. With
`List<Type>`, I can construct a schema with artificial field ids and names at
the caller side. so it is also workable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
