RussellSpitzer commented on code in PR #10496:
URL: https://github.com/apache/iceberg/pull/10496#discussion_r1687151623


##########
api/src/main/java/org/apache/iceberg/StructTransform.java:
##########
@@ -125,6 +151,11 @@ public int hashCode() {
     return Arrays.hashCode(transformedTuple);
   }
 
+  /** Return the schema of transformed result (a flattened structure) */
+  public Schema resultSchema() {

Review Comment:
   My only question here is why we want to produce this as a Schema? Wouldn't 
matching the List<Transforms> fit better here? Then we wouldn't have to create 
artificial fieldId's. If we mostly need Schema out of this api though that 
would make sense though.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to