szehon-ho commented on code in PR #10496:
URL: https://github.com/apache/iceberg/pull/10496#discussion_r1671297464
##########
api/src/main/java/org/apache/iceberg/StructTransform.java:
##########
@@ -125,6 +148,18 @@ public int hashCode() {
return Arrays.hashCode(transformedTuple);
}
+ /**
+ * The transform result type is useful for building a comparator for the
transformed struct (like
+ * {@link SortKey} using {@link Comparators#forType(Types.StructType)}.
+ *
+ * <p>
Review Comment:
Nit: do we need this new paragraph?
##########
api/src/main/java/org/apache/iceberg/StructTransform.java:
##########
@@ -125,6 +148,18 @@ public int hashCode() {
return Arrays.hashCode(transformedTuple);
}
+ /**
+ * The transform result type is useful for building a comparator for the
transformed struct (like
Review Comment:
My thought is, I'm not sure we need to mention the use case for this here,
as it should be generic method. The code reader can just follow the references
to see the use case.
Maybe the return statement in the javadoc suffices ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
