dimas-b commented on code in PR #9940:
URL: https://github.com/apache/iceberg/pull/9940#discussion_r1676113409


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -100,6 +121,16 @@ paths:
 
         Common catalog configuration settings are documented at
         
https://iceberg.apache.org/docs/latest/configuration/#catalog-properties
+
+
+        Capabilities are used by the server to signal supported functionality 
and can be:
+        - tables (default capability in case the `capabilities` property 
doesn't exist or is empty in the response)

Review Comment:
   I tend to think we ought to treat missing `capabilities` and empty 
`capabilities` elements differently.
   
   If the element is present, that means the server is aware and declares its 
capabilities. There's no need to assume any defaults.
   
   If the element is missing, I'd argue that the client should assume support 
for _all_ capabilities at the version level that was current when the client 
was built. Any possible errors that result from accessing unimplemented 
endpoints will have to be logged and debugged by the user, but that's always a 
possibility.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to